815572 - Standardize the Bluetooth permissions name (bluetooth or mozBluetooth)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P2)

Description

[Paul Theriault [:pauljt] (no longer reading bugmail)]

The bluetooth code has the permissions "mozBluetooth" but the PermissionsInstaller.jsm has both bluetooth and mozBluetooth. 

"bluetooth" would be better imho since all other permissions and lowercase and unprefixed, but really I just need to know which is the "correct" one.

Comment 1

[Gene Lian (I already quit Mozilla)]

Nice catch! We're going to hook up the system message mechanism to the permission module and also confused about which one is actually preferred.

If we prefer "bluetooth" then we need to modify the permission check in BluetoothManager.cpp which is still using "mozBluetooth".

All the bluetooth-related apps seems supporting both "bluetooth" and "mozBluetooth".

Comment 2

[Eric Chou [:ericchou] [:echou]]

(In reply to Gene Lian [:gene] from comment #1)
> Nice catch! We're going to hook up the system message mechanism to the
> permission module and also confused about which one is actually preferred.
> 
> If we prefer "bluetooth" then we need to modify the permission check in
> BluetoothManager.cpp which is still using "mozBluetooth".
> 
> All the bluetooth-related apps seems supporting both "bluetooth" and
> "mozBluetooth".

I'm o.k with the change. For Bluetooth module, like Gene mentioned, only one line in BluetoothManager.cpp needs to be modified.

Comment 3

[Gregor Wagner [:gwagner]]

The change is not hard but we have to be careful that we don't break anything. I made a couple of these changes already and the best thing to do is: add new permission to gaia, wait until it gets to all gaia branches, update the permission name in gecko, wait until we land the patch on all branches (including beta), remove old permission from gaia.
I think for bluetooth I already started landing the change on gaia a while back but I never finished landing the gecko change. So it's kind of my mistake that we have this mozBluetooth and bluetooth mess.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Lets change it. I checked the Gaia permissions and they all support mozBluetooth and bluetooth so we are good there.

Comment 5

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed22fe593f97

Comment 6

[Gregor Wagner [:gwagner]]

Attachment: Patch to remove mozBluetooth permission from permission table

This should land once we removed all the mozBluetooth permissions in Gaia.

Comment 7

[Gregor Wagner [:gwagner]]

Attachment: PR pointer

Comment 8

[Gregor Wagner [:gwagner]]

PR 6670 should only land after https://bug815572.bugzilla.mozilla.org/attachment.cgi?id=685760 is distributed to all trees.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ed22fe593f97

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc011fa9cc86
https://hg.mozilla.org/releases/mozilla-beta/rev/6031db9484d0

Comment 11

[Andrew Overholt [:overholt]]

Setting priority based on triage discussions.  Feel free to decrease priority if you disagree.

Comment 12

[Gregor Wagner [:gwagner]]

https://github.com/mozilla-b2g/gaia/commit/0680d1cdc3a9f916fb418a893ccdf4880f136210

Comment 13

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8ee650b33c

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e8ee650b33c

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/607cb05af726
https://hg.mozilla.org/releases/mozilla-beta/rev/03ebd1bd6a34